add custom title and description for athlete profile page

vol1ura · Dec 22, 2023 · 6605a9b · 6605a9b
1 parent d72ab1c
commit 6605a9b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/app/views/activities/_result.html.erb b/app/views/activities/_result.html.erb
@@ -3,7 +3,7 @@
   <td>
     <% if result.athlete_id %>
       <div>
-        <%= link_to result.athlete.name.presence || t('athletes.show.nobody'), result.athlete, class: 'athlete-link' %>
+        <%= link_to result.athlete.name.presence || t('common.nobody'), result.athlete, class: 'athlete-link' %>
       </div>
       <div class="athlete-details fw-lighter">
         <%= t '.total_runs_html', count: @results_count[result.athlete_id] %>
@@ -13,7 +13,7 @@
         <% end %>
       </div>
     <% else %>
-      <%= t 'athletes.show.nobody' %>
+      <%= t 'common.nobody' %>
     <% end %>
   </td>
   <td class="align-middle text-end">

diff --git a/app/views/athletes/show.html.erb b/app/views/athletes/show.html.erb
@@ -1,5 +1,9 @@
+<% athlete_name = @athlete.name || t('common.nobody') %>
+<% head_info :title, athlete_name %>
+<% head_info :description, t('.description', athlete_name:) %>
+
 <h1>
-  <%= @athlete.name || t('.nobody') %>
+  <%= athlete_name %>
   <button type="button" class="btn btn-outline-primary btn-light float-end float-md-none ms-md-3 mb-2" data-bs-toggle="modal" data-bs-target="#barcodeModal">
     <i class="bi bi-upc-scan"></i>
   </button>

diff --git a/config/locales/rs.yml b/config/locales/rs.yml
@@ -473,6 +473,7 @@ rs:
   common:
     without_token: WITHOUT TOKEN (create)
     without_name: WITHOUT NAME
+    nobody: UNKNOWN
     open_link: open
     gender: Pol
     man: Čovek
@@ -559,7 +560,7 @@ rs:
       women: Žene
   athletes:
     show:
-      nobody: UNKNOWN
+      description: 'Athlete profile %{athlete_name}: results, statistics and volunteering'
   activities:
     index:
       description: Recent run results on S95 events

diff --git a/config/locales/ru.yml b/config/locales/ru.yml
@@ -474,6 +474,7 @@ ru:
   common:
     without_token: БЕЗ ТОКЕНА (создать)
     without_name: БЕЗ ИМЕНИ
+    nobody: НЕИЗВЕСТНЫЙ
     open_link: открыть
     gender: Пол
     man: Мужчина
@@ -560,7 +561,7 @@ ru:
       women: Женщины
   athletes:
     show:
-      nobody: НЕИЗВЕСТНЫЙ
+      description: 'Профиль участника %{athlete_name}: результаты, статистика и волонтёрства'
   activities:
     index:
       description: Недавние результаты забегов S95