psql: Fix UPSERT query to respect conflict_target #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Postgres driver, for the following method call:
record.Upsert(ctx, db, false, []string{"foo"}, boil.None(), boil.Infer())
...would omit the conflict_target parameter[1], i.e. `foo`, from the
query:
INSERT INTO "cars" ("id", "foo") VALUES ($1,$2) ON CONFLICT DO NOTHING
This patch changes the behavior so that the conflict_target is
respected, resulting in the following:
INSERT INTO "cars" ("id", "foo") VALUES ($1,$2) ON CONFLICT ("foo") DO NOTHING
Fixes volatiletech#1289
[1] https://www.postgresql.org/docs/15/sql-insert.html#SQL-ON-CONFLICT
agis
force-pushed
the
psql-upsert-conflict_target
branch
from
b926f17 to
a0ded2f
Compare
atzedus
pushed a commit
to atzedus/sqlboiler
that referenced
this pull request
Oct 16, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Postgres driver, for the following method call:
...would omit the conflict_target parameter[1], i.e.
foo, from the query:This patch changes the behavior so that the conflict_target is respected, resulting in the following:
Fixes #1289
[1] https://www.postgresql.org/docs/15/sql-insert.html#SQL-ON-CONFLICT