wip: added --no-schema option scaffolding, needs tests #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly fix the new conflicts 🙏🏾 |
morganhein
force-pushed
the
feat/add-no-schema-argument
branch
from
dc42730 to
583bd69
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
--no-schemaoption, which allows for overriding the default option in the driver.This flag only allows forcefully ignoring the schema, setting
--no-schema=falsedoes not force usage of the schema.This code works, but I'd like some feedback on what else needs to be updated to make this land.
I don't feel confident deciding which tests to update for this, nor if you'd like README stuffs to be updated.
Any guidance is welcome, and i'll do what I can.
Thanks!