Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(template): transfer []byte type in load function #1422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xux1217
Copy link

@xux1217 xux1217 commented Oct 24, 2024

when primary and foreign key is []byte, transfer []byte to string for map key.

This PR also fixes the binary foreign key error in the mysql test schema.

when primary and foreign key is []byte, transfer []byte to string for
map key.
@stephenafamo
Copy link
Collaborator

For a tiny bit more efficiency, I'd prefer to detect the type during generation not at runtime. For example, take a look at how isPrimitive and usesPrimitive are used in the templates.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants