Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix HAVING clause to join multiple conditions #219

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Fix HAVING clause to join multiple conditions #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion queries/_fixtures/08.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SELECT * FROM "a" WHERE (a=$1 or b=$2) AND (c=$3) GROUP BY id, name HAVING id <> $4, length(name, $5) > $6;
SELECT * FROM "a" WHERE (a=$1 or b=$2) AND (c=$3) GROUP BY id, name HAVING id <> $4 AND length(name, $5) > $6;
2 changes: 1 addition & 1 deletion queries/query_builders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ func writeModifiers(q *Query, buf *bytes.Buffer, args *[]interface{}) {
fmt.Fprintf(havingBuf, " HAVING ")
for i, j := range q.having {
if i > 0 {
fmt.Fprintf(havingBuf, ", ")
fmt.Fprintf(havingBuf, " AND ")
}
fmt.Fprintf(havingBuf, j.clause)
*args = append(*args, j.args...)
Expand Down