🎨 rewrite all the action tests with CreateCacheForTest and TestArg #3249
Conversation
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/XXL
|
/assign @k82cn |
pkg/scheduler/cache/util.go
Outdated
| for _, pod := range testArg.Pods { | ||
| schedulerCache.AddPod(pod) | ||
| } | ||
| for _, ss := range testArg.PodGroups { |
There was a problem hiding this comment.
Thanks for your review, fixed
|
New changes are detected. LGTM label has been removed. |
|
can we hold on and waiting for #3269? so that deeply rewrite the UT. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
lifecycle/stale
volcano-sh-bot
added
the
needs-rebase
stale
bot
removed
the
lifecycle/stale
|
@kingeasternsun: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Because the origin PR #2901 has two much different and conflicts with the latest master, So I decided to reopen a new PR.
I refactor the code that build schedule cache in each test cases by using a common function CreateCacheForTest, so the test code is more clear