Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cherry-pick for release-1.8]change private function 'unmarshalSchedulerConf' to public function 'UnmarshalSchedulerConf' #3306

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Lily922
Copy link
Contributor

@Lily922 Lily922 commented Jan 22, 2024

change private function 'unmarshalSchedulerConf' to public function 'UnmarshalSchedulerConf'

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2024
…UnmarshalSchedulerConf'

Signed-off-by: l00500787 <lili133@huawei.com>
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@volcano-sh-bot volcano-sh-bot merged commit 675b8df into volcano-sh:release-1.8 Jan 22, 2024
9 checks passed
@Lily922 Lily922 changed the title change private function 'unmarshalSchedulerConf' to public function 'UnmarshalSchedulerConf' [cherry-pick for release-1.9]change private function 'unmarshalSchedulerConf' to public function 'UnmarshalSchedulerConf' Feb 28, 2024
@Lily922 Lily922 changed the title [cherry-pick for release-1.9]change private function 'unmarshalSchedulerConf' to public function 'UnmarshalSchedulerConf' [cherry-pick for release-1.8]change private function 'unmarshalSchedulerConf' to public function 'UnmarshalSchedulerConf' Feb 28, 2024
@Lily922 Lily922 deleted the v1.8.2-config branch April 7, 2024 07:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants