Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

update go to 1.21 #3321

Merged
merged 1 commit into from
May 9, 2024
Merged

update go to 1.21 #3321

merged 1 commit into from
May 9, 2024

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Feb 18, 2024 •
edited
Loading

Volcano has adapted to k8s1.29 and k8s1.30 will be released soon. We should update the go language version to be consistent with k8s

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2024
@hwdef
Copy link
Member Author

hwdef commented Feb 18, 2024

/assign @lowang-bh @Monokaix

@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@Monokaix
Copy link
Member

Monokaix commented Mar 6, 2024

We'd better add some info like volcano has adapted k8s 1.29 and k8s has used go 1.21 and so we should keep consistent it. Also please update docker build base image to 1.21.

@hwdef
update go to 1.21
301a54d 
Signed-off-by: LX <hwdefcom@outlook.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2024
@hwdef
Copy link
Member Author

hwdef commented Mar 24, 2024

We'd better add some info like volcano has adapted k8s 1.29 and k8s has used go 1.21 and so we should keep consistent it. Also please update docker build base image to 1.21.

Thanks for your suggestions. I fixed this

@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2024
@Monokaix
Copy link
Member

Monokaix commented May 8, 2024

/lgtm

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@volcano-sh-bot volcano-sh-bot merged commit 15df16e into volcano-sh:master May 9, 2024
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@huone1 huone1 Awaiting requested review from huone1

@wpeng102 wpeng102 Awaiting requested review from wpeng102

Assignees

@william-wang william-wang

@Monokaix Monokaix

@lowang-bh lowang-bh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwdef @lowang-bh @Monokaix @volcano-sh-bot @william-wang