Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

skip the jobs that have no tasks during the close session step in gang plugin #4012

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Wang-Kai
Copy link
Contributor

What type of PR is this?

/kind flake
/area scheduling

What this PR does / why we need it:

In the OnSessionClose function, the new PR skip the unavailable job. Unnecessary podgroup condition updates are avoided in the following scenarios:

  1. In the vj deletion scenario, the Pod deletion event is watched earlier than the PG deletion event. At this time, len(jobInfo.Tasks) == 0 && jobInfo.PodGroup != nil, and a new PodGroupUnschedulableType condition is added
  2. In the vj creation scenario, the podgroup has been created but the pod has not been created yet. In this case, a new PodGroupUnschedulableType condition is added similar to scenario 1

Which issue(s) this PR fixes:

Fixes #4011

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

@volcano-sh-bot volcano-sh-bot added kind/flake Categorizes issue or PR as related to a flaky test. area/scheduling labels Feb 14, 2025
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2025
@Wang-Kai Wang-Kai changed the title skip unavailable jobs during the close session step in gang plugin #4011 skip unavailable jobs during the close session step in gang plugin Feb 14, 2025
@Wang-Kai Wang-Kai closed this Feb 14, 2025
@Wang-Kai Wang-Kai reopened this Feb 17, 2025
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2025
Signed-off-by: 王凯 <wangkai05@bilibili.com>
@Wang-Kai Wang-Kai force-pushed the skip-unavailable-job branch from 0a48e4f to 15ebb45 Compare February 17, 2025 13:34
@Wang-Kai Wang-Kai changed the title skip unavailable jobs during the close session step in gang plugin skip the jobs that have no tasks during the close session step in gang plugin Feb 17, 2025
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Feb 17, 2025
@Monokaix
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@volcano-sh-bot volcano-sh-bot merged commit dd2fdf1 into volcano-sh:master Feb 21, 2025
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/scheduling kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boundary Condition Considerations in Gang Plugin's OnSessionClose
4 participants