Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

0701 e2e：add preemption e2e case #893

Closed
wants to merge 2 commits into from
Closed

0701 e2e：add preemption e2e case #893

wants to merge 2 commits into from

Conversation

Thor-wl
Copy link
Contributor

@Thor-wl Thor-wl commented Jul 1, 2020

add a case about invalid queue of incoming preemptor job

@Thor-wl
add e2e case about preemption
c8b8444 
Signed-off-by: Thor <1187526662@qq.com>
@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 1, 2020
@Thor-wl Thor-wl mentioned this pull request Jul 1, 2020
Merged
@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 30b60e30-bb65-11ea-b296-fff192675051

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 1, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 905ebac0-bb70-11ea-b296-fff192675051

@TravisBuddy
Copy link

Hey @Thor-wl,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0950eeb0-bb78-11ea-b296-fff192675051

@TravisBuddy
Copy link

Hey @Thor-wl,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 45ae2f40-bb81-11ea-b296-fff192675051

@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ca85b7f0-bc09-11ea-937a-75d40a178b7c

@Thor-wl
optimize code style according to reivew adivce in PR892
8313066 
Signed-off-by: Thor <1187526662@qq.com>
@k82cn
Copy link
Member

k82cn commented Jul 2, 2020

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@Thor-wl
Copy link
Contributor Author

Thor-wl commented Jul 2, 2020

In essence，this case is same with case "job validate check: invalid queue when create " in admission e2e case. Close pr

@Thor-wl Thor-wl closed this Jul 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thor-wl @TravisBuddy @k82cn @volcano-sh-bot