Skip to content

Update LICENSE-MIT #168

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update LICENSE-MIT #168

wants to merge 1 commit into from

Conversation

maximevtush
Copy link

Updated the copyright year from 2017 to 2025 in the LICENSE file

@vorner
Copy link
Owner

vorner commented Jan 29, 2025

Hmm 🤔

For one, I'm not sure it should be updated to 2025 if there was no change made in 2025.

But apparently, when looking at it, even the tokio-jsonrpc developers part is just a copy-paste from other project and obviously wrong.

I do wonder, how important is it to even have the file in the repository / or the first line? Isn't it enough that git preserves all the copyright info in the commits and that we say what the license is in the Cargo.toml?

@maximevtush
Copy link
Author

Hmm 🤔

For one, I'm not sure it should be updated to 2025 if there was no change made in 2025.

But apparently, when looking at it, even the tokio-jsonrpc developers part is just a copy-paste from other project and obviously wrong.

I do wonder, how important is it to even have the file in the repository / or the first line? Isn't it enough that git preserves all the copyright info in the commits and that we say what the license is in the Cargo.toml?

I can delete the year of copyright

@vorner
Copy link
Owner

vorner commented Feb 8, 2025

Deleting the year and fixing the owner might be the best :-)

@maximevtush
Copy link
Author

Deleting the year and fixing the owner might be the best :-)

what owner might be?

@vorner
Copy link
Owner

vorner commented Feb 22, 2025

I don't know if it's OK to just remove the owner. But if we need one, it would be signal-hook developers instead of tokio-jsonrpc developers

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants