Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mission fix #583

Closed
wants to merge 14 commits into from
Closed

Mission fix #583

wants to merge 14 commits into from

Conversation

mrzzzrm
Copy link

@mrzzzrm mrzzzrm commented Apr 13, 2014

Fixes #564

...by

  • Introducing WorldElement as a future base class of everything, for now only baseclass of Mission and Script
  • Making WorldElement inherit from glow::Referenced and using glow::ref_ptr to keep Missions alive (as some kind of zombie, since they are not update()d anymore) in MissionStatePoll

This is a first step into the direction of what I imagine #542 to look like, but i'd rather deliver it in small bites than in one big PR. The following "issues" will for sure be removed:

  • two update() loops in World::update()
  • double constructors in Script

@mrzzzrm
Copy link
Author

mrzzzrm commented Apr 14, 2014

(Please see this as an arch-proposal, nothing final. I'm fine with reworking it, completely differently, if necessary.)

@@ -1,5 +1,7 @@
#pragma once

#include <iostream>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cough

@mrzzzrm
Copy link
Author

mrzzzrm commented May 29, 2014

The arch introduced here is obsolete by now, fix will follow in another PR

@mrzzzrm mrzzzrm closed this May 29, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mission] gets deleted after success before MissionStatePoll can trigger
2 participants