Provide both a minimal example and a voxpupuli-* example #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 6, 2023
README.md
Outdated
|
|
||
| # The release group is used in gha-puppet's release workflow | ||
| group :release do | ||
| gem 'puppet-blacksmith', '~> 6.0', require: false |
There was a problem hiding this comment.
Suggested change
| gem 'puppet-blacksmith', '~> 6.0', require: false | |
| gem 'puppet-blacksmith', '~> 7.0', require: false |
or did you pin it on purpose to the older version?
bastelfreak
reviewed
Oct 6, 2023
In 2e4b26c the minimal example was rewritten to a voxpupuli-* example, but this goes against a core design principle that the action should be usable without those gems. This commit brings back that minimal example, while also adding a full example with voxpupuli-* gems. The hints to the reader about those are removed from the minimal example. It also raises the upper bounds of versions. Lower bounds are kept at minimum compatible versions.
bastelfreak
approved these changes
Oct 7, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2e4b26c the minimal example was rewritten to a voxpupuli-* example, but this goes against a core design principle that the action should be usable without those gems.
This commit brings back that minimal example, while also adding a full example with voxpupuli-* gems. The hints to the reader about those are removed from the minimal example.