Add curl and remote_file support
#31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for issue voxpupuli#28
Half fix of issue voxpupuli#28
…_file'` I forgot to add it in the previous commit.
|
Thanks for sending this along. Any chance you can add some tests for the new features? At some point in the future it may make sense to drop wget and curl in favor of remote_file too. |
|
I am not experienced in tests, I will read some doc this week-end and figure out how to do this. |
|
I looked at the tests and realized that allowing wget, curl and remote_file at the same time will make grow the tests 3x larger. I suggest we only keep remote_file and drop the rest. What do you think? |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit provides a new feature and the PR closes #28 :
download_withparameterdownload_with => 'curl'is availabledownload_with => 'remote_file'is availableNote that I did not touch the tests; there might be some work on that part but my knowledge is limited on Gem/Rake.
Please tell me if you like it or not. If you have a question or request, do not hesitate to comment. I'm away from the keyboard this week-end. I will be back Monday.