Add support for RHEL 8 and CentOS 8 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siebrand
commented
Oct 18, 2019
siebrand
commented
- Add key for EPEL-8.
- Update tests for os version 8.
- Add author to contributors.
- Update testing notes.
- Update alternatives.
This was referenced Oct 18, 2019
Closed
danielparks
reviewed
Oct 19, 2019
spec/classes/shared_base.rb
Outdated
|
|
||
| it do | ||
| is_expected.to contain_yumrepo('epel').with( | ||
| mirrorlist: 'https://mirrors.fedoraproject.org/metalink?repo=epel-8&arch=$basearch', |
There was a problem hiding this comment.
You have an extra two spaces of indent here.
danielparks
reviewed
Oct 19, 2019
spec/classes/shared_base.rb
Outdated
| mirrorlist: 'https://mirrors.fedoraproject.org/metalink?repo=epel-7&arch=$basearch', | ||
| gpgkey: 'file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7', | ||
| descr: 'Extra Packages for Enterprise Linux 7 - $basearch' | ||
| mirrorlist: 'https://mirrors.fedoraproject.org/metalink?repo=epel-7&arch=$basearch', |
There was a problem hiding this comment.
…and an extra two spaces of indent here, as well as many other places.
- Add key for EPEL-8. - Update tests for os version 8. - Add author to contributors. - Update testing notes. - Update alternatives.
siebrand
force-pushed
the
support-rhel8-centos8
branch
from
c6fb790 to
37bd12a
Compare
|
Are there any updates on the status of this PR? |
|
Thank you @siebrand! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.