Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to support Praefect #422

Closed
wants to merge 1 commit into from

Conversation

danielgriggs
Copy link

Update to support Praefect configuration

Stolen from #372

Pull Request (PR) description

This PR takes the work done by @rudexi and provides a way to configure Praefect.

This Pull Request (PR) fixes the following issues

Fixes partially #366

@danielgriggs
Copy link
Author

Running the tests locally only show error with things I didn't change, so I guess I didn't make anything worse :P

@smortex
Copy link
Member

smortex commented Nov 10, 2023

REFERENCE.md is outdated

🤔 Did you adjusted REFERENCE.md by hand? Update it with:

$ bundle exec rake strings:generate:reference

Then amend and push your commit, and CI should continue.

@danielgriggs
Copy link
Author

Ah, my work laptop is pretty locked down, so I can only use exactly ruby 2.7, only 2.5.9 or 3.0.4. So bundle is either too out of date or URI is too new and doesn't support the escape() function. Also not being a Ruby developer I can't seem to generate an environment that matches the required environment for the tests.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants