remove exec of wget/curl

replaced with a puppet/archive resource.

manifests/slave.pp

@@ -170,7 +170,6 @@
 
   case $::kernel {
     'Linux': {
-      $fetch_command  = "wget -O ${slave_home}/${client_jar} ${client_url}/${client_jar}"
       $service_name   = 'jenkins-slave'
       $defaults_user  = 'root'
       $defaults_group = 'root'
@@ -186,7 +185,6 @@
       }
     }
     'Darwin': {
-      $fetch_command    = "curl -O ${client_url}/${client_jar}"
       $service_name     = 'org.jenkins-ci.slave.jnlp'
       $defaults_user    = 'jenkins'
       $defaults_group   = 'wheel'
@@ -253,14 +251,9 @@
   }
 
   if ($manage_client_jar) {
-    exec { 'get_swarm_client':
-      command => $fetch_command,
-      path    => '/usr/bin:/usr/sbin:/bin:/usr/local/bin',
-      user    => $slave_user,
-      creates => "${slave_home}/${client_jar}",
-      cwd     => $slave_home,
-      #refreshonly  => true,
-    ## needs to be fixed if you create another version..
+    archive { 'get_swarm_client':
+      source => "${client_url}/${client_jar}",
+      path   => "${slave_home}/${client_jar}",
     }
   }
 
@@ -273,12 +266,12 @@
   }
 
   if ($manage_client_jar) {
-    Exec['get_swarm_client'] ->
-    Service['jenkins-slave']
+    Archive['get_swarm_client'] ->
+      Service['jenkins-slave']
   }
 
   if $install_java and ($::osfamily != 'Darwin') {
     Class['java'] ->
-    Service['jenkins-slave']
+      Service['jenkins-slave']
   }
 }

spec/classes/jenkins_slave_spec.rb

@@ -3,7 +3,7 @@
 describe 'jenkins::slave' do
 
   shared_context 'a jenkins::slave catalog' do
-    it { should contain_exec('get_swarm_client') }
+    it { should contain_archive('get_swarm_client') }
     it { should contain_file(slave_service_file) }
     it { should contain_service('jenkins-slave').with(:enable => true, :ensure => 'running') }
     it { should contain_user('jenkins-slave_user').with_uid(nil) }