Rubocop: Fix Style/DoubleNegation

voxpupuli · Feb 18, 2018 · e7270fd · e7270fd
1 parent f384cf6
commit e7270fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -37,11 +37,6 @@ Style/AccessorMethodName:
     - 'lib/puppet/provider/jenkins_authorization_strategy/cli.rb'
     - 'lib/puppet/provider/jenkins_security_realm/cli.rb'
 
-# Offense count: 1
-Style/DoubleNegation:
-  Exclude:
-    - 'lib/puppet/provider/jenkins_job/cli.rb'
-
 # Offense count: 33
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:

diff --git a/lib/puppet/provider/jenkins_job/cli.rb b/lib/puppet/provider/jenkins_job/cli.rb
@@ -78,7 +78,8 @@ def self.get_job(job, catalog = nil)
   # currently unused
   def self.job_enabled(job, catalog = nil)
     raw = clihelper(['job_enabled', job], catalog: catalog)
-    !!(raw =~ %r{true})
+    return true if raw =~ %r{true}
+    false
   end
   private_class_method :job_enabled