Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

jenkins-slave exposes password as command argument #700

Closed
jhoblitt opened this issue Jan 4, 2017 · 0 comments · Fixed by #710
Closed

jenkins-slave exposes password as command argument #700

jhoblitt opened this issue Jan 4, 2017 · 0 comments · Fixed by #710

Comments

@jhoblitt
Copy link
Member

jhoblitt commented Jan 4, 2017

Instead of using the -password argument, the jenkins-slave init scripts should use -passwordEnvVariable to prevent credentials being leaked via the process table.
@jhoblitt jhoblitt added the bug Something isn't working label Jan 4, 2017
@jhoblitt jhoblitt added security and removed bug Something isn't working labels Jan 15, 2017
jhoblitt added a commit to jhoblitt/puppet-jenkins that referenced this issue Jan 15, 2017
@jhoblitt
do not expose slave password in process table
35e554b 
Setting the swarm client password credential via the `-password`
argument exposes it in the system process table.  Instead, the password
may be set in an env var specified with the `-passwordEnvVariable`
param.

resolves voxpupuli#700
@jhoblitt jhoblitt mentioned this issue Jan 15, 2017
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not expose slave password in process table jhoblitt/puppet-jenkins
1 participant
@jhoblitt