Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix installation of core plugins #188

Merged
merged 1 commit into from
Sep 26, 2014

Conversation

bracki
Copy link
Contributor

@bracki bracki commented Sep 26, 2014

This prevents the 'plugin.jpi.pinned' file
from being deleted.
Otherwise Jenkins always starts to manage the plugin by itself.

See #118 #131

This prevents the 'plugin.jpi.pinned' file
from being deleted.
@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rtyler
Copy link

rtyler commented Sep 26, 2014

Ah good catch! I just noticed some of that code last night but didn't make the connection

rtyler pushed a commit that referenced this pull request Sep 26, 2014
@rtyler rtyler merged commit e5ab7b7 into voxpupuli:master Sep 26, 2014
@rtyler rtyler added this to the 1.3.0 - Bernard milestone Sep 26, 2014
@bracki
Copy link
Contributor Author

bracki commented Sep 26, 2014

Oops.
https://github.com/jenkinsci/puppet-jenkins/blob/e5ab7b7c86a445403d7bb3711ce16ea70f1a90d1/spec/defines/jenkins_plugin_spec.rb#L38

-- Jan

Am 26.09.2014 um 16:59 schrieb "R. Tyler Croy" notifications@github.com:

Merged #188.


Reply to this email directly or view it on GitHub.

@jchristi
Copy link
Contributor

@bracki it would probably make more sense to check for the exec name rather than the command since that is less brittle.

bracki pushed a commit to Jimdo/puppet-jenkins that referenced this pull request Sep 27, 2014
Fixes broken tests for voxpupuli#188
@bracki bracki mentioned this pull request Sep 27, 2014
tmclaugh pushed a commit to hubspotdevops/puppet-jenkins that referenced this pull request Oct 19, 2014
Fixes broken tests for voxpupuli#188
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants