Add ensure=>file to pinning file

[alexjfisher]

Hi

This fix for #465 actually seems too simple. It works for me, but I suspect I'm missing something! :)
But without an 'ensure' property, what did the file resource actually do? Chown files if they happened to exist?

Kind Regards,
Alex

[jhoblitt]

@alexjfisher I agree it is odd that file resource doesn't have an ensure param. I'm not sure if the de#tent was to only set the permissions on the .pinned file, if it exists or to pin all managed plugins. Hmm.

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[sfhardman]

I think the trouble is this would pin all plugins, not just bundled ones which are also being explicitly added. Not sure how big of a deal that is. It may only be an issue if a plugin is not bundled when puppet is applied, but gets added to the bundle on a later Jenkins release.

I suspect the cleanest thing would be to add a "pinned" parameter and let people manually select whether to pin a plugin. #380, and the result of the fix (32c015e) suggests that it is difficult to detect whether a plugin should be pinned automatically, and have it work on first and subsequent applies.

[alexjfisher]

@sfhardman I've added a new parameter to control the behaviour as you suggested. I actually called it 'pin' (instead of 'pinned').

[sfhardman]

Works for me :-)

[jhoblitt]

@rtyler Any thoughts on this?