attempt to determine the correct gem provider #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
maint/gem-provider
branch
from
3da0d01 to
0f7a348
Compare
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
`jenkins::cli::config` currently installs the `retries` gem needed by the xtypes as a convenience -- it is not clear if functionality should be in this class at all or if it should merely be a vehicle for passing data into the catalog. Puppetserver users will still have to manually install the `retries` gem as there is no reliable way to determine if an agent run is configuring a puppet master. resolves voxpupuli#434 resolves voxpupuli#498
jhoblitt
force-pushed
the
maint/gem-provider
branch
from
0f7a348 to
b66e2f6
Compare
jhoblitt
added a commit
that referenced
this pull request
Mar 8, 2016
attempt to determine the correct gem provider
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkins::cli::configcurrently installs theretriesgem needed bythe xtypes as a convenience -- it is not clear if functionality should be
in this class at all or if it should merely be a vehicle for passing
data into the catalog. Puppetserver users will still have to manually
install the
retriesgem as there is no reliable way to determine if anagent run is configuring a puppet master.
resolves #434
resolves #498