Improve spec speed #537
Merged
Improve spec speed #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The test is to make sure that json is used * The size of the json is irrelevant really, just that the right library is used and the json is parsed. * Speeds up test suite a gobsmacking amount with parallel tests (~10 mins -> 1 minute)
| task :parallel_spec do | ||
| require 'parallel_tests/cli' | ||
| Rake::Task[:spec_prep].invoke | ||
| ParallelTests::CLI.new.run('--type test -t rspec spec/classes spec/defines spec/unit'.split) |
There was a problem hiding this comment.
Damn just realised I forgot functions, I did think the speed increase was a little too impressive...
EDIT: nvm, functions is only 2 tests, this is speedy 🚗
There was a problem hiding this comment.
nvm, there's only 2 specs in there, this thing really is fast! 💯
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
petems
force-pushed
the
improve_spec_speed
branch
2 times, most recently
from
e0f3082 to
7906cd4
Compare
|
Note: Repeated running on a dev machine make this faster: |
Also moves parallel_tests out of development group so it's installed on travis Comparison on an 8 core Mac: ``` $ bundle exec rake parallel_spec 746 examples, 0 failures, 10 pendings Took 66 seconds (1:06) ``` Vs. ``` $ bundle exec rake spec Finished in 3 minutes 4.8 seconds (files took 2.14 seconds to load) 746 examples, 0 failures, 10 pending ```
petems
force-pushed
the
improve_spec_speed
branch
from
7906cd4 to
2301f95
Compare
|
Consistant 2 mins ~ specs in Travis 🎆 |
|
Travis doesn't like you @petems |
petems
force-pushed
the
improve_spec_speed
branch
from
e589cd4 to
69e2bb2
Compare
|
Whoops, should be fixed now! 😓 |
|
WHOOO |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes large fixture file, even for non 1.9.3 …
Adds parallel tests rake task …
Comparison on an 8 core Mac:
Vs Vanilla spec:
Changes travis to use parallel specs
Lets speed up that CI!