Move jenkins::params::default_plugins to class param #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch the configuration does not converge. The credentials plugin
is downloaded and installed every configuration run. This patch addresses
the problem by making it possible to override the default configuration of the
credentials plugin with the following hiera data:
jenkins::params::default_plugins: []
jenkins::plugin_hash:
credentials:
version: 2.1.5
digest_string: 7db002e7b053f863e2ce96fb58abb98a9c01b09c
digest_type: sha1
jhoblitt
added
enhancement
|
@jhoblitt this looks good to me, is there anything you were looking for in order for this change to be merged? |
|
It looks like I goofed up and never 'posted' my review comments. I'm not enthusiastic about adding parameters to the params class. #675 is more to my taste but needs some tests. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the configuration does not converge. The credentials plugin
is downloaded and installed every configuration run. This patch addresses the
problem by making it possible to override the default configuration of the
credentials plugin with the following hiera data: