Add browserstack credentials support #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
reviewed
Jan 8, 2019
|
I've kicked travis... one job failed because |
vStone
force-pushed
the
feature/browserstack_credentials
branch
3 times, most recently
from
35c4fe4 to
084fe5d
Compare
( + fix rubocop warning )
vStone
force-pushed
the
feature/browserstack_credentials
branch
from
084fe5d to
2a9c38b
Compare
|
@jhoblitt quick sign-off on this one? I would rather not keep rebasing :) |
|
Thanks for the PR @vStone ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for browserstack credentials