feat: remove shared param validation tests

spec/classes/broker_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'shared_examples_param_validation'
 
 describe 'kafka::broker', type: :class do
   on_supported_os.each do |os, os_facts|
@@ -18,11 +17,18 @@
         }
       end
 
+      it { is_expected.to compile }
       it { is_expected.to contain_class('kafka::broker::install').that_comes_before('Class[kafka::broker::config]') }
       it { is_expected.to contain_class('kafka::broker::config').that_comes_before('Class[kafka::broker::service]') }
       it { is_expected.to contain_class('kafka::broker::service').that_comes_before('Class[kafka::broker]') }
       it { is_expected.to contain_class('kafka::broker') }
 
+      context 'with invalid mirror_url' do
+        let(:params) { { 'mirror_url' => 'invalid' } }
+
+        it { is_expected.not_to compile }
+      end
+
       context 'with manage_log4j => true' do
         let(:params) { { 'manage_log4j' => true } }
 
@@ -95,8 +101,6 @@
           it { is_expected.not_to contain_file('/etc/systemd/system/kafka.service').with_notify('Service[kafka]') }
         end
       end
-
-      it_validates_parameter 'mirror_url'
     end
   end
 end

spec/classes/consumer_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'shared_examples_param_validation'
 
 describe 'kafka::consumer', type: :class do
   on_supported_os.each do |os, os_facts|
@@ -19,11 +18,18 @@
         }
       end
 
+      it { is_expected.to compile }
       it { is_expected.to contain_class('kafka::consumer::install').that_comes_before('Class[kafka::consumer::config]') }
       it { is_expected.to contain_class('kafka::consumer::config').that_comes_before('Class[kafka::consumer::service]') }
       it { is_expected.to contain_class('kafka::consumer::service').that_comes_before('Class[kafka::consumer]') }
       it { is_expected.to contain_class('kafka::consumer') }
 
+      context 'with invalid mirror_url' do
+        let(:params) { { 'mirror_url' => 'invalid' } }
+
+        it { is_expected.not_to compile }
+      end
+
       context 'with manage_log4j => true' do
         let(:params) { { 'manage_log4j' => true } }
 
@@ -55,8 +61,6 @@
           it { is_expected.to contain_service('kafka-consumer') }
         end
       end
-
-      it_validates_parameter 'mirror_url'
     end
   end
 end

spec/classes/mirror_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'shared_examples_param_validation'
 
 describe 'kafka::mirror', type: :class do
   on_supported_os.each do |os, os_facts|
@@ -22,11 +21,18 @@
         }
       end
 
+      it { is_expected.to compile }
       it { is_expected.to contain_class('kafka::mirror::install').that_comes_before('Class[kafka::mirror::config]') }
       it { is_expected.to contain_class('kafka::mirror::config').that_comes_before('Class[kafka::mirror::service]') }
       it { is_expected.to contain_class('kafka::mirror::service').that_comes_before('Class[kafka::mirror]') }
       it { is_expected.to contain_class('kafka::mirror') }
 
+      context 'with invalid mirror_url' do
+        let(:params) { { 'mirror_url' => 'invalid' } }
+
+        it { is_expected.not_to compile }
+      end
+
       context 'with manage_log4j => true' do
         let(:params) { { 'manage_log4j' => true } }
 
@@ -52,8 +58,6 @@
           it { is_expected.to contain_service('kafka-mirror') }
         end
       end
-
-      it_validates_parameter 'mirror_url'
     end
   end
 end

spec/classes/producer_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'shared_examples_param_validation'
 
 describe 'kafka::producer', type: :class do
   on_supported_os.each do |os, os_facts|