Fix reloading php-fpm on trusty & utopic #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu versions newer than precise support reload signals but that feature is disabled by the package maintainer because he builds packages with the same upstart config for precise, too. But because we actually use reload, refreshing the service doesn't work correctly which leads to php-fpm child processes that never get killed. These processes prevent restarting php-fpm altogether. The only fix is manually killing them. See https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1242376 for reference. This patch ensures that reloading is not used on precise and the reload signal USR2 is used for all other supported versions of Ubuntu by creating an upstart override file. /cc @globin @exi
exi
pushed a commit
that referenced
this pull request
Jul 24, 2015
Fix reloading php-fpm on trusty & utopic
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu versions newer than precise support reload signals but that feature is disabled by the package maintainer because he builds packages with the same upstart config for precise, too.
But because we actually use reload, refreshing the service doesn't work correctly which leads to php-fpm child processes that never get killed. These processes prevent restarting php-fpm altogether. The only fix is manually killing them.
See https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1242376 for reference.
This patch ensures that reloading is not used on precise and the reload signal USR2 is used for all other supported versions of Ubuntu by creating an upstart override file.
/cc @globin @exi