-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add CentOS 9 to supported operating systems #195
Conversation
Thanks @kajinamit for this PR! Please address the issues with the acceptance testing so that this can be merged. |
It seems the upstream repo doesn't provide packages for CentOS9 yet. I'll fix that. |
8428e3d
to
85acc3a
Compare
efe3fc2
to
4014103
Compare
d276ac1
to
8188a2b
Compare
The failure in Puppet6 + Ubuntu jobs are irrelevant to this change. it seems something is wrong with fact reference but I don't know why the problem is specific to puppet 6. |
Fixed in some vox repos this way: voxpupuli/puppet-jenkins@860af1e |
I tried to fix it in #201 but I currently do not know why it is not working. |
The quite strange thing is that lsb-release is installed when software-properties-common is installed, but os.distro.codename is not properly looked up. Is it possible that we ignore these failures atm and merge this change ? This has been kept for a while and I don't really like to keep it further because of that clearly broken tests which I'm not sure when we can fix. I've tried a few options I could think of but none of these works, and now I've run out of my ideas honestly speaking. |
FYI, lsb-release isn't present on CentOS 9 at this time : https://bugzilla.redhat.com/show_bug.cgi?id=2012924 |
@kajinamit can you please rebase this one as well? |
CentOS 9 provides the independent rsyslog-logrotate package to install logrotate settings, and this prevents purging the rsyslog package. Error: Execution of '/usr/bin/rpm -e rsyslog' returned 1: error: Failed dependencies: rsyslog = 8.2102.0-101.el9 is needed by (installed) rsyslog-logrotate-8.2102.0-101.el9.x86_64 This change ensures this logrotate package is also purged during clean up.
... because packages for these versions are not yet provided.
This change adds CentOS Stream 9 (aka CentOS 9) to supported operating systems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request (PR) description
This change adds CentOS Stream 9 (aka CentOS 9) to supported operating
systems.
This Pull Request (PR) fixes the following issues
N/A