Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add CentOS 9 to supported operating systems #195

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

kajinamit
Copy link
Contributor

Pull Request (PR) description

This change adds CentOS Stream 9 (aka CentOS 9) to supported operating
systems.

This Pull Request (PR) fixes the following issues

N/A

@ghoneycutt
Copy link
Member

Thanks @kajinamit for this PR! Please address the issues with the acceptance testing so that this can be merged.

@kajinamit
Copy link
Contributor Author

It seems the upstream repo doesn't provide packages for CentOS9 yet. I'll fix that.

@kajinamit kajinamit force-pushed the centos9 branch 3 times, most recently from 8428e3d to 85acc3a Compare March 23, 2022 10:26
@kajinamit kajinamit force-pushed the centos9 branch 3 times, most recently from efe3fc2 to 4014103 Compare March 23, 2022 11:01
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 24, 2022
@kajinamit kajinamit force-pushed the centos9 branch 6 times, most recently from d276ac1 to 8188a2b Compare May 2, 2022 14:56
@kajinamit
Copy link
Contributor Author

The failure in Puppet6 + Ubuntu jobs are irrelevant to this change. it seems something is wrong with fact reference but I don't know why the problem is specific to puppet 6.

@smortex
Copy link
Member

smortex commented May 29, 2022

it seems something is wrong with fact reference but I don't know why the problem is specific to puppet 6.

describe file("/etc/apt/sources.list.d/adiscon-ubuntu-v8-stable-#{fact('os.distro.codename')}.list") do

os.distro.codename needs lsb-release with legacy facter.

Fixed in some vox repos this way: voxpupuli/puppet-jenkins@860af1e

@bastelfreak
Copy link
Member

I tried to fix it in #201 but I currently do not know why it is not working.

@kajinamit
Copy link
Contributor Author

The quite strange thing is that lsb-release is installed when software-properties-common is installed, but os.distro.codename is not properly looked up.

Is it possible that we ignore these failures atm and merge this change ? This has been kept for a while and I don't really like to keep it further because of that clearly broken tests which I'm not sure when we can fix. I've tried a few options I could think of but none of these works, and now I've run out of my ideas honestly speaking.

@jcpunk
Copy link

jcpunk commented Jul 10, 2022

FYI, lsb-release isn't present on CentOS 9 at this time : https://bugzilla.redhat.com/show_bug.cgi?id=2012924

@bastelfreak
Copy link
Member

@kajinamit can you please rebase this one as well?

CentOS 9 provides the independent rsyslog-logrotate package to install
logrotate settings, and this prevents purging the rsyslog package.

Error: Execution of '/usr/bin/rpm -e rsyslog' returned 1: error: Failed dependencies:
        rsyslog = 8.2102.0-101.el9 is needed by (installed) rsyslog-logrotate-8.2102.0-101.el9.x86_64

This change ensures this logrotate package is also purged during
clean up.
... because packages for these versions are not yet provided.
This change adds CentOS Stream 9 (aka CentOS 9) to supported operating
systems.
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhoblitt jhoblitt merged commit ae6baad into voxpupuli:master Jul 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request tests-fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants