Fix wrong condition to detect Ubuntu #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-expert
approved these changes
May 17, 2022
|
Hi @kajinamit , thanks for the PR. Can you please rebase? I merged #201 and that should fix CI. |
The os.family fact retuns 'Debian' in Ubuntu systems. We should use the os.name fact to distinguish Ubuntu from the other Debian families.
smortex
approved these changes
Jul 12, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The os.family fact retuns 'Debian' in Ubuntu systems. We should use
the os.name fact to distinguish Ubuntu from the other Debian families.
This Pull Request (PR) fixes the following issues
N/A