-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add option to generate setfile with multiple hosts and roles #124
Add option to generate setfile with multiple hosts and roles #124
Conversation
6ea3081
to
dee14d1
Compare
dee14d1
to
670fbea
Compare
670fbea
to
e4dd12d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine to me, but I would like to see another reviewer.
I didn't notice #111 until now ... ie gen strings like this for 'myhost1:role1;myhost2;role2' Rename option to --beaker_hosts_and_roles ? or even just --hosts and leave it up to docs that roles are also supported. |
bin/metadata2gha
Outdated
opt.split(';').each do |node| | ||
node_num, roles = node.split(':', 2) | ||
options[:beaker_nodes_and_roles][node_num] = if roles | ||
roles.split(',') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could just keep roles as a string. no need to split it into array.
I'll squash my commits before merge. |
@bastelfreak do I wait for @ekohl to approve before merging? |
Currently traveling, so I didn't take too close of a look but at first glance it looks sensible. @jhoblitt would this also serve your needs? |
I haven't tried it but at a glance I think it would work for me with changes to gha-puppet & modsync_config. |
I put up a branch in puppet-mongodb to verify that my changes are working as expected |
Ah, I'll have to do something in modulesync_config as well to get my new input from .sync.yml to ci.yml |
modulesync_config support fixed in version 7.5.0 (voxpupuli/modulesync_config#888) @ekohl @bastelfreak is it ok to merge and release this now? |
We have a few modules that override the modulesync generated ci.yml because they have integration tests that require multiple hosts with custom roles.
This PR add a new option to
metadata2gha
that can be used to generate setfile strings to bring up multiple hosts in gha.