Add CRD Validation (#962)

ref: https://kubernetes.io/docs/tasks/access-kubernetes-api/extend-api-custom-resource-definitions/#validation
voyagermesh · Apr 1, 2018 · c7ad227 · c7ad227
1 parent f3dac60
commit c7ad227
Show file tree

Hide file tree

Showing 13 changed files with 467 additions and 594 deletions.
diff --git a/apis/voyager/v1beta1/crd.go b/apis/voyager/v1beta1/crd.go
@@ -12,7 +12,6 @@ func (r Ingress) CustomResourceDefinition() *apiextensions.CustomResourceDefinit
 		Plural:        ResourcePluralIngress,
 		Singular:      ResourceSingularIngress,
 		Kind:          ResourceKindIngress,
-		ListKind:      ResourceKindIngress + "List",
 		ShortNames:    []string{"ing"},
 		ResourceScope: string(apiextensions.NamespaceScoped),
 		Labels: crdutils.Labels{
@@ -31,7 +30,6 @@ func (c Certificate) CustomResourceDefinition() *apiextensions.CustomResourceDef
 		Plural:        ResourcePluralCertificate,
 		Singular:      ResourceSingularCertificate,
 		Kind:          ResourceKindCertificate,
-		ListKind:      ResourceKindCertificate + "List",
 		ShortNames:    []string{"cert"},
 		ResourceScope: string(apiextensions.NamespaceScoped),
 		Labels: crdutils.Labels{

diff --git a/apis/voyager/v1beta1/crds.yaml b/apis/voyager/v1beta1/crds.yaml
@@ -10,7 +10,6 @@ spec:
   group: voyager.appscode.com
   names:
     kind: Ingress
-    listKind: IngressList
     plural: ingresses
     shortNames:
     - ing
@@ -109,6 +108,8 @@ spec:
                           errorPage:
                             type: string
                           headers:
+                            additionalProperties:
+                              type: string
                             type: object
                           secretName:
                             type: string
@@ -139,6 +140,8 @@ spec:
                 type: string
               type: array
             nodeSelector:
+              additionalProperties:
+                type: string
               description: 'NodeSelector is a selector which must be true for the
                 pod to fit on a node. Selector which must match a node''s labels for
                 the pod to be scheduled on that node. More info: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/'
@@ -376,7 +379,6 @@ spec:
   group: voyager.appscode.com
   names:
     kind: Certificate
-    listKind: CertificateList
     plural: certificates
     shortNames:
     - cert

diff --git a/glide.lock b/glide.lock
diff --git a/vendor/github.com/appscode/kutil/apiextensions/v1beta1/cli-utils.go b/vendor/github.com/appscode/kutil/apiextensions/v1beta1/cli-utils.go
diff --git a/vendor/github.com/appscode/kutil/apiextensions/v1beta1/convert_types.go b/vendor/github.com/appscode/kutil/apiextensions/v1beta1/convert_types.go
diff --git a/vendor/github.com/pkg/errors/stack.go b/vendor/github.com/pkg/errors/stack.go
diff --git a/vendor/gopkg.in/ini.v1/LICENSE b/vendor/gopkg.in/ini.v1/LICENSE