Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix description for recursive wsdl with extended element #1078

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Fix description for recursive wsdl with extended element #1078

merged 1 commit into from
Jun 18, 2019

Conversation

mastodon0
Copy link
Contributor

I found a bug when using a WSDL that includes recursive types combined with extended elements.
The description of recursive objects would be empty because _.defaultsDeep creates copies of child objects. Using _.defaults only creates the necessary object references and solves the issue.

The testcase shows the problem: We have the types Person -> Department -> Person (HeadOfDepartment)
personDescription.Department.HeadOfDepartment would be an empty object, but should be the same object as personDescription

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.37% when pulling 99ce4e1 on mastodon0:master into be79b70 on vpulim:master.

@jsdevel jsdevel merged commit d1c6a7e into vpulim:master Jun 18, 2019
@jsdevel
Copy link
Collaborator

jsdevel commented Jun 18, 2019

thanks @mastodon0 !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants