Fixed checking for empty obj.Body before further actions

[raviolin]

An error is thrown even if response was succesful.

This is the same as #981 only this doesn't break tests. I decided to make a new pull request because it have been almost a month since #981 was created, and it's author doesn't seem willing to fix tests.

[coveralls]

Coverage remained the same at 93.648% when pulling ccac52d on raviolin:fix-checking-response-body into a142aee on vpulim:master.

[coveralls]

Coverage remained the same at 93.648% when pulling ccac52d on raviolin:fix-checking-response-body into a142aee on vpulim:master.

[raviolin]

I swear it passed all tests on my local machine, but one Travis job failed to npm install for some reason...
https://travis-ci.org/vpulim/node-soap/jobs/299410819

[herom]

@raviolin sorry for letting you down for this long... I had some time off and lost sight of this issue. Could you please try and rebase against the latest master?

I updated our .travis.yaml file in order to test against the latest LTS instead of the latest available version (which seems to fail the tests) - now it should run as expected.

[coveralls]

Coverage remained the same at 93.648% when pulling 21e4d0b on raviolin:fix-checking-response-body into 3db3355 on vpulim:master.

[herom]

Thanks a lot @raviolin 👍

In order to get your PR pushed I'll have to ask for at least 1 test for your contribution as requested per our Guidelines on Submitting a Pull Request

[jsdevel]

why check for obj.html anyway? Does this lib ever use obj.html? Seems we could just move the if statement up and call this good.

[raviolin]

@jsdevel apparently it's necessary in case the client gets an HTML response. There are tests for that.

@herom I'll add a test with a response sample, please don't close this PR yet.

[coveralls]

Coverage remained the same at 93.648% when pulling c7cca26 on raviolin:fix-checking-response-body into 3db3355 on vpulim:master.

[coveralls]

Coverage remained the same at 93.587% when pulling 24736cd on raviolin:fix-checking-response-body into 905eadb on vpulim:master.

[jsdevel]

LGTM

[raviolin]

Can you remove 'needs tests' label? Or should I add more tests?

[herom]

@raviolin I don't know why the label is still there and we haven't merged your PR yet.

Sorry for that... again 🐑 🐑 🐑 😞