Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add drag-model directive in Dialog #1203

Merged
merged 1 commit into from
Jul 1, 2021
Merged

feat: add drag-model directive in Dialog #1203

merged 1 commit into from
Jul 1, 2021

Conversation

xiaoxian521
Copy link
Contributor

@xiaoxian521 xiaoxian521 commented Jun 24, 2021

First of all, thank you for your contribution! 😄

Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

这个变动的性质是

  • 新特性提交
  • 日常 bug 修复
  • 文档改进
  • 组件样式改进
  • 重构
  • 代码风格优化
  • 分支合并
  • 其他改动(是关于什么的改动?)

需求背景

  1. 描述相关需求的来源。
    dialog should drag
  2. 要解决的问题。
    dialog is drag
  3. 相关的 issue 讨论链接。

实现方案和 API(非新功能可选)

  1. 基本的解决思路和其他可选方案。
    only define drag instructions
  2. 列出最终的 API 实现和用法。
    // modal props
    {
    drag: true
    }
  3. 涉及UI/交互变动需要有截图或 GIF。

对用户的影响和可能的风险(非新功能可选)

  1. 这个改动对用户端是否有影响?影响的方面有哪些?
    nothing
  2. 是否有可能隐含的 break change 和其他风险?
    nothing

Changelog 描述(非新功能可选)

  1. 英文描述
  2. 中文描述(可选)

请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • Changelog 已提供或无须提供

后续计划(非新功能可选)

如果这个提交后面还有相关的其他提交和跟进信息,可以写在这里。

@sendya sendya self-assigned this Jun 29, 2021
@sendya sendya merged commit daa22af into vueComponent:master Jul 1, 2021
@sendya
Copy link
Member

sendya commented Jul 12, 2021

This pr has been Revert #1209

issue:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants