Skip to content

fix: add slotFlags for implicit default slots #637

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Mar 29, 2023

🤔 What is the nature of this change?

  • New feature
  • Fix bug
  • Style optimization
  • Code style optimization
  • Performance optimization
  • Build optimization
  • Refactor code or style
  • Test related
  • Other

🔗 Related Issue

mentioned in #541

💡 Background or solution

Results in the same output for

<Comp>
  <div />
</Comp>

and

<Comp>
  { () => <div /> }
</Comp>

and

<Comp>
  {{ default: () => <div /> }}
</Comp>

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for vue-jsx-explorer ready!

Name Link
🔨 Latest commit 453d99f
🔍 Latest deploy log https://app.netlify.com/sites/vue-jsx-explorer/deploys/67b5906432718e00087ba364
😎 Deploy Preview https://deploy-preview-637--vue-jsx-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KaelWD KaelWD force-pushed the fix/541-implicit-slotFlags branch from 6a883d2 to abc2d8e Compare March 29, 2023 17:06
@KaelWD KaelWD marked this pull request as ready for review March 29, 2023 17:20
@KaelWD KaelWD marked this pull request as draft March 30, 2023 09:08
@KaelWD
Copy link
Contributor Author

KaelWD commented Mar 30, 2023

Too aggressive, the existing rule already breaks certain object slots.

@KaelWD KaelWD force-pushed the fix/541-implicit-slotFlags branch from abc2d8e to a7bdf1f Compare February 19, 2025 08:03
@KaelWD KaelWD force-pushed the fix/541-implicit-slotFlags branch from a7bdf1f to 453d99f Compare February 19, 2025 08:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant