feat(runtime-dom): ensure mode is always 'open' when attaching shadow…

…Root
vuejs · Feb 28, 2025 · 2485cba · 2485cba
1 parent f77ba12
commit 2485cba
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/runtime-dom/src/apiCustomElement.ts b/packages/runtime-dom/src/apiCustomElement.ts
@@ -53,7 +53,7 @@ export type VueElementConstructor<P = {}> = {
 export interface CustomElementOptions {
   styles?: string[]
   shadowRoot?: boolean
-  shadowRootOptions?: ShadowRootInit
+  shadowRootOptions?: Omit<ShadowRootInit, 'mode'>
   nonce?: string
   configureApp?: (app: App) => void
 }
@@ -264,7 +264,7 @@ export class VueElement
         )
       }
       if (_def.shadowRoot !== false) {
-        this.attachShadow(extend({ mode: 'open' }, _def.shadowRootOptions))
+        this.attachShadow(extend({}, _def.shadowRootOptions, { mode: 'open' }) as ShadowRootInit)
         this._root = this.shadowRoot!
       } else {
         this._root = this