Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

unmounted hook of directive on teleport's child is called twice. #3497

Closed
07akioni opened this issue Mar 28, 2021 · 1 comment · Fixed by #3499
Closed

unmounted hook of directive on teleport's child is called twice. #3497

07akioni opened this issue Mar 28, 2021 · 1 comment · Fixed by #3499
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working

Comments

@07akioni
Copy link
Contributor

Version

3.0.9

Reproduction link

https://codesandbox.io/s/divine-sun-jk15p?file=/src/main.js

image

Steps to reproduce

Follow the link.

What is expected?

unmounted hook is called once.

What is actually happening?

It is called twice.

The bug is introduced since v3.0.8
@HcySunYang HcySunYang added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Mar 29, 2021
@HcySunYang HcySunYang mentioned this issue Mar 29, 2021
Merged
@ota-meshi ota-meshi mentioned this issue Mar 29, 2021
Closed
@holtwick
Copy link

Please bump this up, it is a showstopper for i18n and <teleport> use, see intlify/vue-i18n#412

@tangjinzhou tangjinzhou mentioned this issue Mar 29, 2021
Closed
1 task
@Liwoj Liwoj mentioned this issue Mar 29, 2021
Closed
yyx990803 pushed a commit that referenced this issue Mar 29, 2021
@HcySunYang
fix(runtime-core): avoid unmount teleport's children multiple times (#…
3736496 
…3499)

fix #3497
@inottn inottn mentioned this issue Mar 30, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): avoid unmount teleport's children multiple times
3 participants
@holtwick @HcySunYang @07akioni