Skip to content

fix(runtime-core): reset current node when the KeepAlive slots default is null #11787

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 3 commits into from

Conversation

linzhe141
Copy link
Contributor

@linzhe141 linzhe141 commented Sep 3, 2024

Copy link

github-actions bot commented Sep 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+7 B) 37.7 kB (+3 B) 33.9 kB (-7 B)
vue.global.prod.js 159 kB (+7 B) 57.5 kB 51.2 kB (-3 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB (+7 B) 26.3 kB 23.9 kB (-2 B)

Copy link

pkg-pr-new bot commented Sep 3, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11787

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11787

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11787

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11787

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11787

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11787

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11787

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11787

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11787

vue

pnpm add https://pkg.pr.new/vue@11787

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11787

commit: 93be585

@linzhe141
Copy link
Contributor Author

duplicate of #11778

@linzhe141 linzhe141 closed this Sep 3, 2024
@linzhe141 linzhe141 reopened this Sep 3, 2024
@linzhe141 linzhe141 closed this Sep 3, 2024
@edison1105
Copy link
Member

这个改动是不对的。#10632 曾经这么改过一次,引发了#10827。因为问题比较严重,当时回退了 #10632, 如果一定要这么改,需要防止 #10827 再次出问题,但 #10827 的作者已经删除了复现仓库,现在也没办法调查了。我已经联系了 #10827 的作者,希望能找到那个复现。

@linzhe141 linzhe141 deleted the fix-keepalive-transtion branch December 12, 2024 11:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

同时使用KeepAlive和Transition, Transition使用out-in模式, 使用include控制缓存的组件, 可能导致out-in失效
2 participants