Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(reactivity): rely on dirty check only when computed has deps #11931

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

jh-leong
Copy link
Member

close #11929

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+8 B) 37.9 kB (+4 B) 34.1 kB (+24 B)
vue.global.prod.js 159 kB (+8 B) 57.8 kB (+5 B) 51.4 kB (+10 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB (+8 B) 18.8 kB (+4 B) 17.2 kB
createApp 55.4 kB (+8 B) 21.3 kB (+4 B) 19.4 kB (+13 B)
createSSRApp 59.4 kB (+8 B) 23 kB (+5 B) 21 kB (+46 B)
defineCustomElement 60.1 kB (+8 B) 22.8 kB (+5 B) 20.8 kB (+3 B)
overall 69.1 kB (+8 B) 26.3 kB (+3 B) 24 kB (+2 B)

Copy link

pkg-pr-new bot commented Sep 15, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11931

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11931

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11931

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11931

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11931

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11931

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11931

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11931

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11931

vue

pnpm add https://pkg.pr.new/vue@11931

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11931

commit: d83df63

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

triggerRef causes computed callback to never invoke
4 participants