Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(compiler-sfc): add scoping tag to trailing universal selector #12918

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thecodewarrior
Copy link

close #12906

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38.1 kB 34.3 kB
vue.global.prod.js 158 kB 58 kB 51.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.7 kB
createApp 54.6 kB 21.3 kB 19.4 kB
createSSRApp 58.8 kB 23 kB 21 kB
defineCustomElement 59.4 kB 22.9 kB 20.8 kB
overall 68.6 kB 26.4 kB 24.1 kB

Copy link

pkg-pr-new bot commented Feb 20, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12918

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12918

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12918

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12918

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12918

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12918

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12918

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12918

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12918

vue

npm i https://pkg.pr.new/vue@12918

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12918

commit: 9b0bf77

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 20, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member

/ecosystem-ci run nuxt

@vue-bot
Copy link
Contributor

vue-bot commented Feb 20, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
nuxt success success

@edison1105 edison1105 requested a review from Doctor-wu February 20, 2025 00:53
@edison1105 edison1105 added scope: sfc 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 20, 2025
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Feb 20, 2025
@edison1105
Copy link
Member

LGTM

Copy link
Member

@Doctor-wu Doctor-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: sfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Star selectors leak scoped styles into children
4 participants