-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
fix(runtime-dom): use KeepAlive and CustomElement at same time(#6934) #6966
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it always to trigger a unmounted hook. I think this shadowDom should be cached rather than rebuilt.
could you give me a example in playground? |
|
this link is |
You just need to replace the domain part, |
I know your means. I think maybe that author didn't think about this situation that use customElement in KeepAlive. |
for KeepAlive,it should be moved instead of unmount.but in customElements,it can only be unmount |
I suggest that do not use customElement in KeepAlive |
I will try to make it possible. but it is difficult to merge by member. so you'd better stop to use like this or wait for next version |
if you use KeepAlive and CustomElement.CustomElement will not recreate.so the property of "_resolved" would be "true",it means that should update it