-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(app): support app level effect scope #8801
Open
Mini-ghost
wants to merge
11
commits into
vuejs:main
Choose a base branch
from
Mini-ghost:feat/app-effect-scope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e5b7951
feat(app): support app level effect scope
Mini-ghost 96a3b32
Update packages/runtime-dom/src/index.ts
Mini-ghost d2a5fb3
refactor(app): implement in `runtime-core` instead of `runtime-dom`
Mini-ghost 26fbb03
test: test for app-level effect scope
Mini-ghost 6ed7c41
Update packages/runtime-core/src/apiCreateApp.ts
Mini-ghost d1fccaa
Merge branch 'main' into feat/app-effect-scope
Mini-ghost ce6dbfa
Merge branch 'main' into feat/app-effect-scope
Mini-ghost e79ad7d
Merge branch 'main' into feat/app-effect-scope
Mini-ghost a519233
Merge branch 'main' into feat/app-effect-scope
Mini-ghost f8f37d9
Merge branch 'main' into feat/app-effect-scope
Mini-ghost a7141d4
feat: adding an effectScope to app instance
Mini-ghost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me wonder if the effectScope should be in app context 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@posva In the latest commit (a7141d4), I added
scope
to the app. Currently, I have handled it as a private property. Should it be made public for user access?