Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(link): add view-transition prop #2356

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

posva
Copy link
Member

@posva posva commented Sep 11, 2024

<template>
  <RouterLink to="/some-page" view-transition>
    Go to some page
  </RouterLink>
</template>

Limitations:

  • Since it the view transition triggers right away, the DOM visually freezes until the navigation is completed but it still allows to have a nice effect with minimal code

Example by Evan

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit bd2dd8c
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/66e1b99dacb2d40008d7df26

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.31%. Comparing base (be68148) to head (bd2dd8c).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
packages/router/src/RouterLink.ts 76.19% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2356      +/-   ##
==========================================
- Coverage   97.39%   97.31%   -0.08%     
==========================================
  Files          26       26              
  Lines        6020     6040      +20     
  Branches      824      827       +3     
==========================================
+ Hits         5863     5878      +15     
- Misses        155      159       +4     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva posva merged commit e978eb8 into main Nov 13, 2024
5 of 6 checks passed
@posva posva deleted the feat/router-link-view-transition-prop branch December 5, 2024 09:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant