Refactor openWebsite

vuejs · Feb 12, 2021 · 0879543 · 0879543
1 parent bad5284
commit 0879543
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/client/vueMain.ts b/client/vueMain.ts
@@ -88,9 +88,6 @@ function registerRestartVLSCommand(context: vscode.ExtensionContext, client: Lan
 }
 
 function registerCustomClientNotificationHandlers(client: LanguageClient) {
-  client.onNotification('$/openWebsite', (url: string) => {
-    vscode.env.openExternal(vscode.Uri.parse(url));
-  });
   client.onNotification('$/showVirtualFile', (virtualFileSource: string, prettySourceMap: string) => {
     setVirtualContents(virtualFileSource, prettySourceMap);
   });

diff --git a/server/src/services/vls.ts b/server/src/services/vls.ts
@@ -61,6 +61,7 @@ import { createEnvironmentService } from './EnvironmentService';
 import { getVueVersionKey } from '../utils/vueVersion';
 import { accessSync, constants, existsSync } from 'fs';
 import { sleep } from '../utils/sleep';
+import { URI } from 'vscode-uri';
 
 interface ProjectConfig {
   vlsFullConfig: VLSFullConfig;
@@ -474,7 +475,7 @@ export class VLS {
    * Custom Notifications
    */
   openWebsite(url: string): void {
-    this.lspConnection.sendNotification('$/openWebsite', url);
+    this.lspConnection.window.showDocument({ uri: URI.parse(url).toString(), external: true });
   }
 
   /**