Skip to content

docs: mention navigateFallback option for PWA App Shell caching #4973

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 21, 2019
Merged

docs: mention navigateFallback option for PWA App Shell caching #4973

merged 1 commit into from
Dec 21, 2019

Conversation

clementmas
Copy link
Contributor

@clementmas clementmas commented Dec 18, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

The navigateFallback option is disabled by default but it is crucial to make an SPA work offline.

I was struggling to make my app work offline until I found this comment: #717 (comment)
So I believe this should be mentioned in the docs.

Feel free to update the wording.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was going to say navigateFallback is mentioned in the docs linked below but your point about it's being crucial for offline mode to work is correct, Approved :)

@NataliaTepluhina NataliaTepluhina merged commit 3f15b4c into vuejs:master Dec 21, 2019
@vue-bot
Copy link

vue-bot commented Dec 21, 2019

Hey @clementmas, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants