-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
support vue.config.cjs #5293
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
support vue.config.cjs #5293
Conversation
I have no idea why AppVeyor is failed 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored some of the loading and testing logic in #5305
You can sync with the dev branch and then fix the Windows testing following that PR.
I merged dev, the tests also passes, thank you! |
I worked out a different solution which uses But I don’t know which one is more suitable. dev...simon300000:import(vue.config.js) Should I open a different PR/issue to discuss about it? |
Thank you very much for the help! I'd very like to support the Out of the same concern, we've made the So, as of now, I think we'd go with the implementation in this PR to support IMO we should support async loading of the config before supporting ESM imports, so that we can avoid using |
if
"type": "module"
was set in package.json, the vue service will emit error.this pr enable use of
vue.config.cjs
, as a simple solution in those environment.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
close #5046
It would be nice if
import()
is used instead ofrequire()
, which will support both commonjs and module, but this makes the whole process asynchronous and many code need to be changed.