Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ensure Dev Tool is enabled in Vue 3 runtime #5788

Merged
merged 3 commits into from
Aug 14, 2020

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Aug 14, 2020

The old alias @vue/runtime-dom was introduced because webpack HMR has
trouble with pure re-exports. Now that the vue.runtime.esm-bundler.js
file also includes a call to initDev, it's no longer an issue. This
also enables Dev Tool in Vue 3 runtime.

Fixes #5785

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

The old alias `@vue/runtime-dom` was introduced because webpack HMR has
trouble with pure re-exports. Now that the `vue.runtime.esm-bundler.js`
file also includes a call to `initDev`, it's no longer an issue. This
also enables Dev Tool in Vue 3 runtime.

Fixes vuejs#5785
Copy link

@d-pollard d-pollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initDev() Not being called in the browser
2 participants