Skip to content

fix(css-modules): css-loader >= v4 compat #1824

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

Airkro
Copy link

@Airkro Airkro commented Apr 23, 2021

fix css module with css-loader >= v4

support:

  • options.esmodule: true
  • options.module.namedExport: true

fix #1788, #1794, #1709, #1612, #1866

@Airkro
Copy link
Author

Airkro commented May 9, 2021

I try to write more tests about more css-loader versions and options, but streamich/memfs#542 block everything.

For anyone who isn't a team member, test suites are too complicated like a black box.

@Airkro Airkro force-pushed the fix/css-loader-compat branch from c7dd9cb to 91c162b Compare July 22, 2021 07:36
@Airkro Airkro changed the title fix(pitcher): css-loader >= v4 compat fix(css-modules): css-loader >= v4 compat Jul 22, 2021
@Airkro Airkro force-pushed the fix/css-loader-compat branch from ac3849e to ab1eb06 Compare July 22, 2021 08:56
@Airkro Airkro force-pushed the fix/css-loader-compat branch from 04f9b72 to ff7612d Compare September 1, 2021 02:32
@Airkro Airkro marked this pull request as draft September 1, 2021 02:38
@Airkro Airkro force-pushed the fix/css-loader-compat branch 2 times, most recently from 59bc403 to 9c12194 Compare September 1, 2021 03:07
@Airkro Airkro closed this Oct 25, 2021
@Airkro Airkro deleted the fix/css-loader-compat branch December 15, 2021 02:18
@Airkro Airkro restored the fix/css-loader-compat branch December 16, 2021 06:51
@Airkro Airkro deleted the fix/css-loader-compat branch December 16, 2021 07:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS modules documentation uses invalid css-loader options object
1 participant