Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

scrollBehavior does not run on load #3196

Closed
Calvin-LL opened this issue May 13, 2020 · 1 comment · Fixed by #3199
Closed

scrollBehavior does not run on load #3196

Calvin-LL opened this issue May 13, 2020 · 1 comment · Fixed by #3199

Comments

@Calvin-LL
Copy link
Contributor

Calvin-LL commented May 13, 2020 •
edited
Loading

Version

3.1.6

Reproduction link

https://codesandbox.io/s/vue-routing-example-pk4q2

Steps to reproduce

Load page

What is expected?

scrollBehavior always return { x: 0, y: 200 } so the scroll position should always be 200 pixels from the top

What is actually happening?

scrollBehavior always return { x: 0, y: 200 } but scroll position y is always 0 when first loaded
@Calvin-LL Calvin-LL mentioned this issue May 13, 2020
Merged
@Calvin-LL
Copy link
Contributor Author

relevant issues: nuxt/nuxt#4024
similar problem in forum post: https://forum.vuejs.org/t/scroll-behaviour-doesnt-work-on-initial-page-load/69210/2
similar problem in stackoverflow post: https://stackoverflow.com/questions/45201014/how-to-handle-anchors-bookmarks-with-vue-router/45206192#45206192

posva added a commit that referenced this issue Jun 18, 2020
@Calvin-LL @posva
fix(scroll): run scrollBehavior on initial load (fix #3196) (#3199)
84398ae 
* Add handleScroll on initial history.transitionTo

* Update index.js

* test(scroll-behavior): add tests for scrollBehavior on load

* refactor(scroll-behavior): scrollBehavior on load

* style: remove spaces

* fix: handleScroll not called with from

* test(scroll-behavior): remove redundant tests

* fix: call handleScroll only if initial navigation succeeds

Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
@rtibbles rtibbles mentioned this issue Aug 12, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(scroll): run scrollBehavior on initial load (fix #3196) Calvin-LL/vue-router
1 participant
@Calvin-LL