Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Render props on auto stubs #834

Merged
merged 3 commits into from
Jul 29, 2018
Merged

Render props on auto stubs #834

merged 3 commits into from
Jul 29, 2018

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Jul 19, 2018

closes #708

eddyerburgh
eddyerburgh requested changes Jul 19, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

Can you add a test please?

@eddyerburgh
Copy link
Member

eddyerburgh commented Jul 28, 2018 •
edited
Loading

I'll add a test :)

Do you have an example where this.$attrs should be rendered?

@eddyerburgh eddyerburgh merged commit 8db502d into vuejs:dev Jul 29, 2018
@shell362
Copy link

You are my heroes, guys! 👍

@eddyerburgh eddyerburgh mentioned this pull request Aug 1, 2018
Closed
kuitos pushed a commit to kuitos/vue-test-utils that referenced this pull request Aug 2, 2018
@Akryum @kuitos
feat: render props on auto stubs (vuejs#834)
7120621
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add child-Prop in stub of ChildComponent (when using snapshot)
3 participants
@Akryum @eddyerburgh @shell362